Skip to content

Network connection provider and hook #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

myty
Copy link
Contributor

@myty myty commented May 26, 2021

  • Related GitHub issue(s) linked in PR description
  • Destination branch merged, built and tested with your changes
  • Code formatted and follows best practices and patterns
  • Code builds cleanly (no additional warnings or errors)
  • Manually tested
  • Automated tests are passing
  • No decreases in automated test coverage
  • Documentation updated (readme, docs, comments, etc.)
  • Localization: No hard-coded error messages in code files (minimally in string constants)

@codecov
Copy link

codecov bot commented May 26, 2021

Codecov Report

Merging #80 (a4548a5) into main (a8e1b5b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #80   +/-   ##
=======================================
  Coverage   95.25%   95.25%           
=======================================
  Files          17       17           
  Lines         295      295           
  Branches       31       31           
=======================================
  Hits          281      281           
  Misses         13       13           
  Partials        1        1           
Impacted Files Coverage Δ
src/tests/factories/factory-type.ts 100.00% <ø> (ø)
src/tests/factories/index.ts 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8e1b5b...a4548a5. Read the comment docs.

@myty myty force-pushed the feature/use-network-information branch from 3dc6e9c to daaa22d Compare May 27, 2021 12:45
@myty myty force-pushed the feature/use-network-information branch from daaa22d to 7a66e0c Compare May 28, 2021 12:34
@myty myty marked this pull request as ready for review June 22, 2021 12:16
@myty myty requested review from a team, brandongregoryscott and wintondeshong June 22, 2021 12:16
@myty myty changed the title Network information provider and hook Network connectionprovider and hook Jun 22, 2021
@myty myty changed the title Network connectionprovider and hook Network connection provider and hook Jun 22, 2021
Copy link
Contributor

@brandongregoryscott brandongregoryscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments for cleanup, but looks good overall 👍

@brandongregoryscott
Copy link
Contributor

I forgot to mention - all of these will need to be exported from index.ts for consumer usage 👍

Copy link
Contributor

@brandongregoryscott brandongregoryscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor changes w/ the factory setup - thanks again for getting this ported over 👍

@myty myty requested a review from brandongregoryscott June 25, 2021 11:17
@myty myty requested a review from brandongregoryscott June 25, 2021 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants