-
Notifications
You must be signed in to change notification settings - Fork 8
Network connection provider and hook #80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
myty
commented
May 26, 2021
•
edited
Loading
edited
- Related GitHub issue(s) linked in PR description
- Destination branch merged, built and tested with your changes
- Code formatted and follows best practices and patterns
- Code builds cleanly (no additional warnings or errors)
- Manually tested
- Automated tests are passing
- No decreases in automated test coverage
- Documentation updated (readme, docs, comments, etc.)
- Localization: No hard-coded error messages in code files (minimally in string constants)
Codecov Report
@@ Coverage Diff @@
## main #80 +/- ##
=======================================
Coverage 95.25% 95.25%
=======================================
Files 17 17
Lines 295 295
Branches 31 31
=======================================
Hits 281 281
Misses 13 13
Partials 1 1
Continue to review full report at Codecov.
|
3dc6e9c
to
daaa22d
Compare
daaa22d
to
7a66e0c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments for cleanup, but looks good overall 👍
src/providers/network-connection/network-connection-provider.tsx
Outdated
Show resolved
Hide resolved
src/providers/network-connection/network-connection-provider.tsx
Outdated
Show resolved
Hide resolved
src/providers/network-connection/network-connection-provider.tsx
Outdated
Show resolved
Hide resolved
src/providers/network-connection/network-connection-provider.test.tsx
Outdated
Show resolved
Hide resolved
src/providers/network-connection/network-connection-provider.tsx
Outdated
Show resolved
Hide resolved
I forgot to mention - all of these will need to be exported from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some minor changes w/ the factory setup - thanks again for getting this ported over 👍