Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete and Read Async methods #49

Merged
merged 2 commits into from
Apr 22, 2022
Merged

Delete and Read Async methods #49

merged 2 commits into from
Apr 22, 2022

Conversation

klauffer
Copy link
Contributor

@klauffer klauffer commented Apr 8, 2022

This will resolve #34 and #17

@klauffer
Copy link
Contributor Author

klauffer commented Apr 8, 2022

There are tests that I forgot to write. it got lost in the tediousness. so review this but know another commit will be coming

@codecov
Copy link

codecov bot commented Apr 8, 2022

Codecov Report

Merging #49 (6d881ff) into main (38cb2c8) will decrease coverage by 2.38%.
The diff coverage is 14.20%.

@@            Coverage Diff             @@
##             main      #49      +/-   ##
==========================================
- Coverage   61.93%   59.55%   -2.39%     
==========================================
  Files         104      106       +2     
  Lines        2919     3071     +152     
  Branches      330      330              
==========================================
+ Hits         1808     1829      +21     
- Misses       1079     1210     +131     
  Partials       32       32              
Impacted Files Coverage Δ
src/Conductors/RepositoryReadConductor.cs 0.00% <ø> (ø)
src/Conductors/RepositoryReadConductorAsync.cs 0.00% <0.00%> (ø)
src/Conductors/RepositoryUpdateConductor.cs 0.00% <ø> (ø)
src/Conductors/RepositoryConductorAsync.cs 28.08% <5.00%> (-47.78%) ⬇️
src/Conductors/RepositoryUpdateConductorAsync.cs 90.00% <90.00%> (ø)
src/Conductors/RepositoryConductor.cs 83.80% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38cb2c8...6d881ff. Read the comment docs.

Copy link
Contributor

@jstevenson jstevenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks pretty good. Thanks for doing this!

There are a few places where code is calling obsolete code, so these will need to be updated:

RepositoryReadConductor.cs
lines 103, 112, 123, 134, 145

LockingConductor.cs
lines 135, 184, 204, 229, 250

@klauffer klauffer merged commit 7d9d4da into rsm-hcd:main Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Async variants to IRepository and repository conductor interfaces
2 participants