Skip to content

Fix fragmentation bug #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
echistyakov wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix fragmentation bug #147

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions internal/socket/duplex.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1092,10 +1092,20 @@ func (dc *DuplexConnection) sendPayload(
}
dc.doSplit(d, m, func(index int, result fragmentation.SplitResult) {
flag := result.Flag
isLastFragment := !result.Flag.Check(core.FlagFollow)

if index == 0 {
flag |= frameFlag
// Remove (C)omplete flag, unless this is the last fragment.
if !isLastFragment {
flag &^= core.FlagComplete
}
} else {
flag |= core.FlagNext
// Set (C)omplete flag, if the original frame had it and this is the last fragment.
if isLastFragment && frameFlag.Check(core.FlagComplete) {
flag |= core.FlagComplete
}
}

// lazy release at last frame
Expand Down
Loading