Test build

[JonRowe]

No description provided.

[pirj]

/home/pirj/source/rspec-expectations/lib/rspec/matchers/dsl.rb:75: warning: method redefined; discarding old exist
/home/pirj/source/rspec-expectations/lib/rspec/matchers.rb:596: warning: previous definition of exist was here

[pirj]

https://github.com/alexrothenberg/ammeter/pull/68/files#diff-bffb236072e25d0e628532ccc5d2e03c2f3f4b446c93ea97ac6d215582cc5333R5

[JonRowe]

Yes I agree! I've been working on a fix, basically just rewriting rspec-rails tests to not need that matcher.

[pirj]

Wrapping the file path string into something that

- subject(:generator_spec) { file("spec/generator/posts_generator_spec.rb") }
+ subject(:generator_spec) { Pathname.new(file("spec/generator/posts_generator_spec.rb")) }

fixes those issues.

But I think this would be better alexrothenberg/ammeter#70

[JonRowe]

That PR will break our specs again as expect a string in places, did you check what effect that has on the contain matcher which we use extensively?

[pirj]

That’s weird. It was late night but I recall making that change in a live ammeter directory and that make our rspec-rails spec run green. I didn’t check cucumber though.
I didn’t think about the compatibility of your change and my ammeter patch though.
Let me check in the evening.