This repository was archived by the owner on Feb 10, 2026. It is now read-only.
Implement groupwise() and layer_axial_lines()#393
Open
lionel- wants to merge 7 commits intorstudio:mainfrom
Open
Implement groupwise() and layer_axial_lines()#393lionel- wants to merge 7 commits intorstudio:mainfrom
lionel- wants to merge 7 commits intorstudio:mainfrom
Conversation
Contributor
Author
|
CMD CHECK passes when I add: #' @importFrom dplyr arrange_ distinct_ group_by_ summarise_ mutate_
#' arrange_ select_ filter_ distinct_ slice_ rename_ transmute_ groups
#' ungroupShould I add this to the PR? |
Contributor
Author
|
ok, I had to remove manually the offending changes to NAMESPACE. The dplyr verbs were originally exported as |
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello. This implements:
groupwise()to set the Vega "group" reference. I named itgroupwise()because I foundprop_group()to be confusing. An alternative could befrom_group().layer_axial_lines()to draw vertical or horizontal lines.I added support for the rule mark in order to draw the lines. In the future, we'll be able to use the rule mark to implement something like
layer_sloped_lines(), but this needs to be fixed first: https://github.com/trifacta/vega/issues/123. Also, it was necessary to prevent ggvis from writing a "from" tag to a mark in the case where no property makes use of data.Here is an example of using a group property:
As for
layer_axial_lines(), it will draw one horizontal line for eachydata point, and one vertical line for eachxdata point. Here the vertical lines are drawn from a data set while the horizontal line is set with:=.Let me know if you're interested in this PR and I'll send the copyright form.