Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pull Connect 2024.12.0 to dev #886

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

Pull Connect 2024.12.0 to dev #886

wants to merge 3 commits into from
+9 −9

Conversation

ianpittwood
Copy link
Collaborator

No description provided.

@ianpittwood ianpittwood requested review from a team, bschwedler and costrouc as code owners December 30, 2024 15:51
@schloerke
Copy link

(The rstudio/connect GitHub team has 35 members. Please only make PR review requests directly. Thank you 😃 )

@schloerke schloerke removed the request for review from a team December 30, 2024 15:55
@ianpittwood
Copy link
Collaborator Author

(The rstudio/connect GitHub team has 35 members. Please only make PR review requests directly. Thank you 😃 )

Hi, @schloerke. rstudio/connect was the team we were told to add as codeowners for this repo by the Connect team. Please submit a PR to appropriately narrow down the individuals automatically added in the CODEOWNERS file and I would be happy to get that updated.

@schloerke
Copy link

schloerke commented Dec 30, 2024 •
edited
Loading

Please submit a PR to appropriately narrow down the individuals automatically added in the CODEOWNERS file and I would be happy to get that updated.

TIL. Thank you, will do!

**Update: TIL CODEOWNERS file will auto assign reviewers given particular file changes. Originally added in #363. I do not have a stake in this repo to thoughtfully make a change. Skipping PR.

bschwedler
bschwedler approved these changes Jan 2, 2025
View reviewed changes
Copy link
Contributor

@bschwedler bschwedler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Although it does look like the Docker Hub credentials may need to be refreshed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bschwedler bschwedler bschwedler approved these changes

@costrouc costrouc Awaiting requested review from costrouc costrouc is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ianpittwood @schloerke @bschwedler @melissa-barca @edavidaja