Skip to content

Conversation

matsl
Copy link
Collaborator

@matsl matsl commented Sep 30, 2025

What

  • Cut dependency cycle
  • Remove duplicate defvar
  • Remove redundant requires

Why

Running latest Emacs (tip version) with no byte compilation gives the
following warning message:

 stop  Warning (emacs): loaddefs-gen: load error
	(error Eager macro-expansion failure: (error "Eager macro-expansion skipped due to cycle:
  … => (load \"hbut.el\") => (macroexpand-all …) => (macroexpand (eval-and-compile …)) => (load \"hbdata.el\") => (load \"hgnus.el\") => (load \"hvar.el\") => (load \"hsettings.el\") => (load \"hproperty.el\") => (load \"hbut.el\")"))

This dependency is cut in the PR by using declare-function.

The duplicated defvar was found when looking at this issue.

@matsl matsl requested a review from rswgnu September 30, 2025 10:14
@rswgnu
Copy link
Owner

rswgnu commented Oct 4, 2025

  • Fix conflicts.

@matsl matsl force-pushed the cleanup branch 2 times, most recently from 6253dc5 to 914a3e9 Compare October 5, 2025 14:48
@matsl matsl merged commit dc30415 into master Oct 5, 2025
4 checks passed
@matsl matsl deleted the cleanup branch October 5, 2025 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants