Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete .ci.rosinstall to fix ign_ros2_controll installation in CI. #9

Merged
merged 1 commit into from
Aug 24, 2023

Conversation

ShotaAk
Copy link

@ShotaAk ShotaAk commented Aug 24, 2023

What does this implement/fix?

ign_ros2_controllはaptでインストールできるので、.ci.rosinstallファイル経由でのインストールが不要になりました。
そのため、.ci.rosinstallファイルを削除します。

Does this close any currently open issues?

いいえ

How has this been tested?

GitHub AciontsのCIが成功することを確認します。

また、#8 がaptでインストールしたign_ros2_controlで動作することを確認済みです。

Checklists

@ShotaAk ShotaAk added the Type: Maintenance Repository Maintenance label Aug 24, 2023
@ShotaAk ShotaAk requested a review from Kuwamai August 24, 2023 06:37
Copy link
Contributor

@Kuwamai Kuwamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMです

@Kuwamai Kuwamai merged commit 44a1292 into ros2 Aug 24, 2023
2 checks passed
@Kuwamai Kuwamai deleted the remove_gz_ros2_controll_installation branch August 24, 2023 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Maintenance Repository Maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants