Fixed due to esp32 package 3.0.1 update #20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Memory usage change @ 9e30418
Click for full report table
Click for full report CSV |
ShotaAk
suggested changes
Jun 18, 2024
uROS_STEP10_tfMsg/interrupt.ino
Outdated
| @@ -1,4 +1,4 @@ | |||
| // Copyright 2023 RT Corporation | |||
| // Copyright 2024 RT Corporation | |||
There was a problem hiding this comment.
Copyrightには発行年を記載します。
このリポジトリはすでにオープンにしているので、発行年の更新は不要です。
他の変更も削除お願いします。
Comment on lines
204
to
207
| g_timer0 = timerBegin(1000000); //1us | ||
| timerAttachInterrupt(g_timer0, &onTimer0); | ||
| timerAlarm(g_timer0, 1000, true, 0); //1kHz | ||
| timerStart(g_timer0); |
There was a problem hiding this comment.
Pi:Co V2 リポジトリと同様に、 //1MHz(1us) と //1000 * 1us(1kHz) 表記に変更お願いします。
他のコメントも同様に対応お願いします。
|
Memory usage change @ 6190cf2
Click for full report table
Click for full report CSV |
|
LGTMです |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix?
ESP32 package 3.0.1にアップデートに合わせた修正
Does this close any currently open issues?
ありません
How has this been tested?
実機で動作確認をしました
Any other comments?
ブランチ名が3.0.0になっていますが、実際のesp32 packageは3.0.1を使っています。
Checklists