Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

シミュレータ環境でSLAMとNavigationを実行 #77

Merged
merged 11 commits into from
Feb 22, 2024

Conversation

YusukeKato
Copy link
Contributor

@YusukeKato YusukeKato commented Feb 5, 2024

What does this implement/fix?

Gazebo上でSLAMとNavigationを実行できるように変更します。

Does this close any currently open issues?

しません。

How has this been tested?

SLAMの動作確認

lidarは"urg"、"lds"、"rplidar"のうちいずれかを指定

ros2 launch raspimouse_gazebo raspimouse_with_lakehouse.launch.py lidar:=urg

ジョイスティックコントローラで操作

ros2 launch raspimouse_ros2_examples teleop_joy.launch.py joydev:="/dev/input/js0" joyconfig:=f710 mouse:=false

SLAMを実行

ros2 launch raspimouse_slam pc_slam.launch.py

十分走らせて地図を作成したら、次のコマンドで地図を保存

ros2 run nav2_map_server map_saver_cli -f ~/MAP_NAME

Navigationの動作確認

lidarは"urg"、"lds"、"rplidar"のうちいずれかを指定

ros2 launch raspimouse_gazebo raspimouse_with_lakehouse.launch.py lidar:=urg

ナビゲーションを実行(マップのパスを指定)

ros2 launch raspimouse_navigation pc_navigation.launch.py map:=/home/ubuntu/MAP_NAME.yaml

Any other comments?

raspimouse_descriptionパッケージのadd-slam-navigationブランチが必要です。

rt-net/raspimouse_description#52

raspimouse_slam_navigation_ros2パッケージも必要です。

https://github.com/rt-net/raspimouse_slam_navigation_ros2

Checklists

@YusukeKato YusukeKato changed the title シミュレータ環境にSLAMとNavigationを実装 シミュレータ環境でSLAMとNavigation Feb 8, 2024
@YusukeKato YusukeKato changed the title シミュレータ環境でSLAMとNavigation シミュレータ環境でSLAMとNavigationを実行 Feb 8, 2024
@YusukeKato YusukeKato marked this pull request as ready for review February 8, 2024 06:53
@YusukeKato YusukeKato self-assigned this Feb 9, 2024
@YusukeKato YusukeKato added the Type: Feature New Feature label Feb 9, 2024
Copy link

@ShotaAk ShotaAk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

動作OKです。コメント確認おねがいします。

README.md Outdated

端末2で次のコマンドを実行すると、Navigationが実行されます。
```sh
ros2 launch raspimouse_navigation pc_navigation.launch.py map:=/path/to/MAP_NAME.yaml
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

コピペでコマンドを実行できるように、下記に変更お願いします。

Suggested change
ros2 launch raspimouse_navigation pc_navigation.launch.py map:=/path/to/MAP_NAME.yaml
ros2 launch raspimouse_navigation pc_navigation.launch.py map:=$HOME/MAP_NAME.yaml

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

英語READMEの方も修正お願いします

README.md Outdated
```sh
ros2 launch raspimouse_navigation pc_navigation.launch.py map:=/path/to/MAP_NAME.yaml
```
`map:=/path/to/MAP_NAME.yaml`はSLAMで作成した地図ファイルのパスを指定してください。
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

下記のように修正してください

Suggested change
`map:=/path/to/MAP_NAME.yaml`はSLAMで作成した地図ファイルのパスを指定してください
引数`map`にはSLAMで作成した地図ファイルのパスを指定してください

@@ -0,0 +1,48 @@
# The MIT License (MIT)
#
# Copyright 2023 RT Corporation <support@rt-net.jp>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Copyright 2023 RT Corporation <support@rt-net.jp>
# Copyright 2024 RT Corporation <support@rt-net.jp>

YusukeKato and others added 4 commits February 22, 2024 14:45
Co-authored-by: Shota Aoki <s.aoki@rt-net.jp>
Co-authored-by: Shota Aoki <s.aoki@rt-net.jp>
Co-authored-by: Shota Aoki <s.aoki@rt-net.jp>
Copy link

@ShotaAk ShotaAk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ShotaAk ShotaAk merged commit 90fd430 into ros2 Feb 22, 2024
1 check passed
@ShotaAk ShotaAk deleted the add-slam-navigation branch February 22, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature New Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants