Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROS 2 Jazzyに対応します #14

Merged
merged 11 commits into from
Nov 20, 2024
Merged

ROS 2 Jazzyに対応します #14

merged 11 commits into from
Nov 20, 2024

Conversation

chama1176
Copy link
Contributor

@chama1176 chama1176 commented Jul 8, 2024

What does this implement/fix?

ROS 2 Jazzyに対応します

  • ドキュメントをJazzy向けに書き換えました
  • CIをJazzyに変更しました
  • ignの記載が残っていた部分をgzに移行しています
  • 起動時の姿勢によらずエラーが出ないように可動範囲を広げています

Does this close any currently open issues?

No.

How has this been tested?

CIでのチェックと
display.launchでロボットが表示されることを確認しています

Any other comments?

2024 Jul 18現在, rvizの問題でstlに色が付きません。
こちらのPRで修正したので、Jazzyにバックポートされたのちリリースされると色がつくようになるはずです。

Checklists

@chama1176 chama1176 marked this pull request as draft July 8, 2024 10:08
@chama1176 chama1176 changed the title Feature/support jazzy ROS 2 Jazzyに対応します Jul 18, 2024
@chama1176 chama1176 marked this pull request as ready for review July 19, 2024 05:11
@chama1176 chama1176 requested a review from Kuwamai July 19, 2024 05:11
@chama1176 chama1176 mentioned this pull request Jul 29, 2024
2 tasks
Copy link
Collaborator

@Kuwamai Kuwamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chama1176
RViz上でモデルが表示できることを確認しました。
rt-net/sciurus17_ros#158 にてGazeboが起動しないため、xacro側に原因があるかもしれません。リンク先のPRをご確認お願いします。

@chama1176
Copy link
Contributor Author

@Kuwamai
指摘いただいた通り、動かなくなっていたので修正しました

Copy link
Collaborator

@Kuwamai Kuwamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chama1176 LGTMです

@Kuwamai Kuwamai added the Type: Feature New Feature label Nov 20, 2024
@Kuwamai Kuwamai merged commit 2d37b80 into ros2 Nov 20, 2024
@Kuwamai Kuwamai deleted the feature/support-jazzy branch November 20, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature New Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants