Fixes #30 UI addition for signup and login modal#55
Open
vanamraghu wants to merge 6 commits intomainfrom
Open
Conversation
1. KlinicAuthform that handles both login & signUp modal 2. KlinicAuthContainer that has tabs to switch b/w login and signup and render the login/signup form 3. Added clsx in package json and installed to handle multiple classes
rt4914
requested changes
Oct 6, 2024
Owner
rt4914
left a comment
rt4914
left a comment
There was a problem hiding this comment.
@vanamraghu I have created this video which should help you understand how we should think about creating scalable solutions.
https://www.loom.com/share/0ee4064f30ac49e3afe1cc2ae9175c89?sid=1f947cac-e84d-435c-a05c-bc2bd456883d
…nto 30-feature-request-ui-add-loginsignup-modal
1. KlinicAuthForm renamed to AuthForm that displays the form for login and sign up 2. Modal component created to display the login and sign up form and also state is handled to display modal when close button is clicked or anywhere in the page 3. KlinicAuthContainer is removed and renamed to Modal component 4. Button component modified so that first logo can be displayed following the button text (earlier it was text followed by children) now children is displayed followed by button text 5. Header component is created to display the LogIn button so that when clicked modal and related forms is displayed
1. Removed clsx and making use of classNames to handle display of conditionals for tailwind
…ignup-modal' into 30-feature-request-ui-add-loginsignup-modal # Conflicts: # package-lock.json
Owner
|
Unassigned myself as this PR is not ready for the review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Addition of login button in header so that when clicked it should display the modal and when close button is clicked it closes the modal
Addition of Signup and Login modal to handle sign up and login process,
Form is added that can be reused that has Email and password
Related Tickets & Documents
QA Instructions, Screenshots, Recordings