Skip to content

Add Missing Field Modal For Won status #215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
May 23, 2025

Conversation

Siddhantsingh1230
Copy link

@Siddhantsingh1230 Siddhantsingh1230 commented May 21, 2025

Description

Previously, setting an opportunity to Won showed a toast if required project fields were missing, with no way to fill them. This PR adds a modal to collect all required fields upfront, improving the user experience.

Relevant Technical Choices

  • Add Missing Field Modal to show all fields

Testing Instructions

  • Open an opportunity on next_crm.
  • Update status to Won.
  • It should open up a Modal (if Project specific values are empty)

Additional Information:

  • N/A

Screenshot/Screencast

Missing.Field.Modal.webm

Checklist

  • I have carefully reviewed the code before submitting it for review.
  • This code is adequately covered by unit tests to validate its functionality.
  • I have conducted thorough testing to ensure it functions as intended.
  • A member of the QA team has reviewed and tested this PR (To be checked by QA or code reviewer)

Addresses https://github.com/rtCamp/erp-rtcamp/issues/2155#issuecomment-2883071739

@Aryan20
Copy link
Collaborator

Aryan20 commented May 22, 2025

@Siddhantsingh1230, can we ensure that this pop-up only opens if PMS is installed? Otherwise, a pop-up is not needed.

@Siddhantsingh1230
Copy link
Author

Siddhantsingh1230 commented May 22, 2025

can we ensure that this pop-up only opens if PMS is installed? Otherwise, a pop-up is not needed.

Can we add a checkbox field to the Opportunity Doctype via the rtcamp app, labeled "Create Project from Opportunity" (with the description: "Automatically create a project when the opportunity is marked as won")? This field should default to true and will be used in the frontend to trigger the "Missing Fields" modal flow. Implementing this should satisfy our use case and eliminate the dependency of any external apps on NCRM.

cc: @KanchanChauhan / @niraj2477

@Siddhantsingh1230 Siddhantsingh1230 merged commit 442701f into develop May 23, 2025
4 checks passed
@Siddhantsingh1230 Siddhantsingh1230 deleted the feat/add-update-opportunity-modal branch May 26, 2025 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants