Open
Conversation
Signed-off-by: ayushnirwal <53055971+ayushnirwal@users.noreply.github.com>
Signed-off-by: ayushnirwal <53055971+ayushnirwal@users.noreply.github.com>
Signed-off-by: ayushnirwal <53055971+ayushnirwal@users.noreply.github.com>
Signed-off-by: ayushnirwal <53055971+ayushnirwal@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Introduces a new “Allocations” section in the frontend app by adding dedicated routes, sidebar navigation, and a shared allocations page layout (with an initial Team toolbar shell).
Changes:
- Added
/allocations/teamand/allocations/projectroutes under a new Allocations layout. - Updated the sidebar to expose Allocations navigation entries.
- Refactored parts of Timesheet filtering types/UI (notably the personal timesheet header filters).
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| frontend/packages/app/src/types/timesheet.ts | Adjusts TimesheetFilters optionality/nullability for filter fields. |
| frontend/packages/app/src/route.tsx | Adds Allocations layout + team/project routes. |
| frontend/packages/app/src/pages/timesheet/personal/index.tsx | Replaces filter components with inline TextInput/Select controls. |
| frontend/packages/app/src/pages/allocations/team/index.tsx | Adds initial Team allocations toolbar shell with search + filters. |
| frontend/packages/app/src/pages/allocations/project/index.tsx | Adds placeholder Project allocations page shell. |
| frontend/packages/app/src/pages/allocations/layout.tsx | Adds Allocations header with breadcrumb view-switch dropdown and “Add allocation” CTA. |
| frontend/packages/app/src/lib/constant.ts | Replaces old allocation route constant with new allocations routes. |
| frontend/packages/app/src/layout/sidebar/index.tsx | Adds Allocations section to sidebar and updates GlobalSearch items. |
| frontend/packages/app/src/components/filters/searchTasks.tsx | Removes the reusable SearchTasks filter component. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: ayushnirwal <53055971+ayushnirwal@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Screenshot/Screencast
Checklist
Fixes #930