Fix: Inconsistent use of class and instance methods in test setup#923
Open
shreyas5522 wants to merge 2 commits intortCamp:mainfrom
Open
Fix: Inconsistent use of class and instance methods in test setup#923shreyas5522 wants to merge 2 commits intortCamp:mainfrom
shreyas5522 wants to merge 2 commits intortCamp:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the shared TestNextPms test base class to make its setup helpers consistent with setUpClass usage (class context) and makes request helper methods more defensive when merging request parameters.
Changes:
- Converted
setup_project_manager_roleandassign_roles_to_userfrom instance methods to@classmethodand updated call sites accordingly. - Made
get()/post()merge logic tolerateNoneinputs when adding the session id (sid). - Minor docstring/formatting touch-ups in the test base class.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an inconsistency in the test setup where an instance method was being called from a class method (
setUpClass).Previously,
setup_project_manager_roleandassign_roles_to_userwere defined as instance methods (usingself) but were invoked from a class context usingclsinsidesetUpClass. This mismatch could lead to runtime errors such as missing required positional arguments and results in inconsistent method design.Changes made:
setup_project_manager_roleto a class methodassign_roles_to_userto a class methodclsinstead ofselfAdditionally:
Nonevalues in request parameters (paramsanddata) to prevent runtime errors when merging dictionariesThis improves code correctness, consistency, and robustness without changing existing functionality.