feat : backport populate_post_content_inner_blocks #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Ta5r <srv.tanay@gmail.com>
justlevine
force-pushed
the
feat/backporting_populate_post_content_inner_blocks
branch
2 times, most recently
from
8e2e921 to
0980c00
Compare
justlevine
approved these changes
Dec 18, 2024
There was a problem hiding this comment.
Tracking: wpengine#326
@Ta5r the issue with your test was infinite recursion: you were using a PostContent block inside the WP_Post.post_content, so it kept trying to replace itself.
Take a look at the diff to see how I used the Term as an intermediary.
Co-authored-by: Ta5r <srv.tanay@gmail.com>
Co-authored-by: Ta5r <srv.tanay@gmail.com>
justlevine
force-pushed
the
feat/backporting_populate_post_content_inner_blocks
branch
from
0980c00 to
5381c84
Compare
justlevine
deleted the
feat/backporting_populate_post_content_inner_blocks
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What you did in this PR ?
Back ported functionality to populate innerBlocks of the
core/post-contentblock with the parsed blocks.Why is it necessary ?
To ensure
core/post-contentblock dynamically includes blocks from the post content.How ?
populate_post_content_inner_blocksto fetch the post's content, parse it into blocks, and assign it to the innerBlocks property if available.Tasks :
populate_post_content_inner_blocks.