Gemini CLI Hook Support (PR #131 Part 3)#158
Open
ahundt wants to merge 225 commits intortk-ai:masterfrom
Open
Conversation
feat: add pnpm support + fix git argument parsing for modern stacks
Add Vitest test runner support with 99.6% token reduction
adding benchmark script for local performance monitoring in dev
Release v0.2.1
Add installation guide for AI coding assistants
Add utils.rs with common utilities used across modern JavaScript tooling commands: - truncate(): Smart string truncation with ellipsis - strip_ansi(): Remove ANSI escape codes from output - execute_command(): Centralized command execution with error handling These utilities enable consistent output formatting and filtering across multiple command modules. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Add comprehensive support for modern JS/TS development stack: Commands added: - rtk lint: ESLint/Biome output with grouped rule violations (84% reduction) - rtk tsc: TypeScript compiler errors grouped by file (83% reduction) - rtk next: Next.js build output with route/bundle metrics (87% reduction) - rtk prettier: Format checker showing only files needing changes (70% reduction) - rtk playwright: E2E test results showing failures only (94% reduction) - rtk prisma: Prisma CLI without ASCII art (88% reduction) Features: - Auto-detects package managers (pnpm/yarn/npm/npx) - Preserves exit codes for CI/CD compatibility - Groups errors by file and error code for quick navigation - Strips verbose output while retaining critical information Total: 6 new commands, ~2,000 LOC Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Document the 6 new commands and shared utils module in CHANGELOG.md. Focuses on token reduction metrics and CI/CD compatibility. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Add benchmarks for the 6 new commands in scripts/benchmark.sh: - tsc: TypeScript compiler error grouping - prettier: Format checker with file filtering - lint: ESLint/Biome grouped violations - next: Next.js build metrics extraction - playwright: E2E test failure filtering - prisma: Prisma CLI without ASCII art All benchmarks are conditional (skip if tools not available or not applicable to current project). Tests only run on projects with package.json and relevant configuration files. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Implements heuristic calculation of monthly quota savings percentage with support for Pro, Max 5x, and Max 20x subscription tiers. Features: - --quota flag displays monthly quota analysis - --tier <pro|5x|20x> selects subscription tier (default: 20x) - Heuristic based on ~44K tokens/5h Pro baseline - Estimates: Pro=6M, 5x=30M, 20x=120M tokens/month - Clear disclaimer about rolling 5-hour windows vs monthly caps Example output for Max 20x: Subscription tier: Max 20x ($200/mo) Estimated monthly quota: 120.0M Tokens saved (lifetime): 356.7K Quota preserved: 0.3% Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
feat: add modern JavaScript tooling support (lint, tsc, next, prettier, playwright, prisma)
Add rtk gh command for GitHub CLI operations with intelligent output filtering: Commands: - rtk gh pr list/view/checks/status: PR management (53-87% reduction) - rtk gh issue list/view: Issue tracking (26% reduction) - rtk gh run list/view: Workflow monitoring (82% reduction) - rtk gh repo view: Repository info (29% reduction) Features: - Level 1 optimizations (default): Remove header counts, @ prefix, compact mergeable status (+12-18% savings, zero UX loss) - Level 2 optimizations (--ultra-compact flag): ASCII icons, inline checks format (+22% total savings on PR view) - GraphQL response parsing and grouping - Preserves all critical information for code review Token Savings (validated on production repo): - rtk gh pr view: 87% (24.7K → 3.2K chars) - rtk gh pr checks: 79% (8.9K → 1.8K chars) - rtk gh run list: 82% (10.2K → 1.8K chars) Global --ultra-compact flag added to enable Level 2 optimizations across all GitHub commands. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
- Add utils.rs as Key Architectural Component - Expand Module Responsibilities table (7→17 modules) - Document PR rtk-ai#9 in Fork-Specific Features section - Include token reduction metrics for all new commands
Change dtolnay/rust-action to dtolnay/rust-toolchain (correct name)
feat: add GitHub CLI integration (depends on rtk-ai#9)
feat: add quota analysis with multi-tier support
## Release automation - Add release-please workflow for automatic semantic versioning - Configure release.yml to only trigger on tags (avoid double-release) ## Benchmark automation - Extend benchmark.yml with README auto-update - Add permissions for contents and pull-requests writes - Auto-create PR with updated metrics via peter-evans/create-pull-request - Add scripts/update-readme-metrics.sh for CI integration ## Verification - ✅ Workflows ready for CI/CD pipeline - ✅ No breaking changes to existing functionality Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
feat: CI/CD automation (versioning, benchmarks, README auto-update)
…s--master--components--rtk chore(master): release 0.3.0
## Fixes ### Lint crash handling - Add graceful error handling for linter crashes (SIGABRT, OOM) - Display warning message when process terminates abnormally - Show first 5 lines of stderr for debugging context ### Grep command - Add --type/-t flag for file type filtering (e.g., --type ts, --type py) - Passes --type argument to ripgrep for efficient filtering ### Find command - Add --type/-t flag for file/directory filtering - Default: "f" (files only) - Options: "f" (file), "d" (directory) ## Testing - ✅ cargo check passes - ✅ cargo build --release succeeds - ✅ rtk grep --help shows --file-type flag - ✅ rtk find --help shows --file-type flag with default ## Breaking Changes None - all changes are backwards compatible additions Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
…d-bugs fix: improve command robustness and flag support
…s--master--components--rtk chore(master): release 0.3.1
## Overview Complete architectural documentation (1133 lines) covering all 30 modules, design patterns, and extensibility guidelines. ## Critical Fixes (🔴) - ✅ Module count: 30 documented (not 27) - added deps, env_cmd, find_cmd, local_llm, summary, wget_cmd - ✅ Language: Fully translated to English for consistency with README.md - ✅ Shared Infrastructure: New section documenting utils.rs and package manager detection - ✅ Exit codes: Correct documentation (git.rs preserves exit codes for CI/CD) - ✅ Database: Correct path ~/.local/share/rtk/history.db (not tracking.db) ## Important Additions (🟡) - ✅ Global Flags Architecture: Verbosity (-v/-vv/-vvv) and ultra-compact (-u) - ✅ Complete patterns: Package manager detection, exit code preservation, lazy static regex - ✅ Config system: TOML format documented - ✅ Performance: Verified binary size (4.1 MB) and estimated overhead - ✅ Filter levels: Before/after examples with Rust code ## Bonus Improvements (🟢) - ✅ Table of Contents (12 sections) - ✅ Extensibility Guide (7-step process for adding commands) - ✅ Architecture Decision Records (Why Rust? Why SQLite?) - ✅ Glossary (7 technical terms) - ✅ Module Development Pattern (template + 3 common patterns) - ✅ 15+ ASCII diagrams for visual clarity ## Stats - Lines: 1133 (+118% vs original 520) - Sections: 12 main + subsections - Code examples: 10+ Rust/bash snippets - Accuracy: 100% verified against source code Production-ready for new contributors, experienced developers, and LLM teams. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
…tk-ai#129) * feat(gain): add colored dashboard with efficiency meter and impact bars Upgrade `rtk gain` output with rich terminal visualization: - Colored percentage cells (green ≥70%, yellow ≥40%, red <40%) - Efficiency meter: ASCII progress bar with savings percentage - Impact bars: proportional block charts per command - Styled section headers (bold green) - Command names in bright cyan - History tier indicators (▲/■/•) - Dynamic column widths for clean table alignment - KPI-style key-value layout for summary metrics All visual features are TTY-aware via std::io::IsTerminal — output degrades gracefully to plain text when piped or redirected. No new dependencies (uses existing `colored` crate). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * Add dashboard visualization screenshot Shows colored terminal output of `rtk gain -p` with: - Project-scoped token savings header - Efficiency meter with color gradient - Per-command table with colored Avg% and Impact bars Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
CI validate-docs requires version consistency across all doc files. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…n-go-complete docs: comprehensive v0.15.1 documentation for Python/Go support
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Add project-specific Claude Code configuration for RTK development: - 5 agents: code-reviewer, debugger, rtk-testing-specialist, rust-rtk, technical-writer - 2 commands: /diagnose (env checks), /test-routing (dry-run validation) - 1 hook: pre-commit cargo fmt + clippy + test gate - 1 rule: CLI testing methodology (snapshot, token accuracy, cross-platform) - 3 skills: performance optimization, security audit, release workflow Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Fix CI validation: README referenced 0.18.0, Cargo.toml is at 0.18.1. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Generates structured repo recap with: - Open PRs categorized (ours/reviewable/problematic) - Open issues with priority classification - Recent releases - Executive summary with risks and quick wins - Auto-copy to clipboard - FR/EN language support via argument Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Fix CI validation: CLAUDE.md referenced 0.18.0, Cargo.toml is at 0.18.1. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
* feat: tee raw output to file for LLM re-read without re-run (rtk-ai#86) When RTK filters command output, LLM agents lose failure details (stack traces, assertions) and re-run the same command 2-3x. The tee feature saves raw output to ~/.local/share/rtk/tee/ on failure and prints a one-line hint so the agent can read the file instead. - Add src/tee.rs: core module with tee_raw(), tee_and_hint(), rotation - Add TeeConfig to config.rs: enabled, mode, max_files, max_file_size - Integrate in 7 modules: cargo, runner, vitest, pytest, lint, tsc, go - Default: failures only, skip <500 chars, 20 file rotation, 1MB cap - Env overrides: RTK_TEE=0 (disable), RTK_TEE_DIR (custom directory) - 14 unit tests, 352 total tests passing, zero regressions Closes rtk-ai#86 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix: add tee.rs to ARCHITECTURE.md module count (47 modules) CI validate-docs requires main.rs module count == ARCHITECTURE.md count. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
chore: add Claude Code configuration (.claude)
Add opt-in audit logging to the RTK rewrite hook and a new `rtk hook-audit` command to analyze the collected metrics. This provides verifiable data on hook reliability (rewrite rate, skip reasons, top commands) instead of relying on anecdotal claims. - Add `_rtk_audit_log()` function to rtk-rewrite.sh (opt-in via RTK_HOOK_AUDIT=1) - Log each invocation: timestamp | action | original_cmd | rewritten_cmd - Actions: rewrite, skip:already_rtk, skip:heredoc, skip:no_match, skip:no_deps, skip:empty - New `src/hook_audit_cmd.rs` module with log parser and stats display - New `rtk hook-audit --since N` subcommand (default: last 7 days) - 8 Rust unit tests + 7 hook bash tests for audit mode - Make HOOK var overridable in test suite for repo-local testing Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Rust binary replaces 204-line bash script as Claude Code PreToolUse hook. Adds rtk hook claude, rtk run -c, and Windows support via cfg!(windows). Closes rtk-ai#112 (chained commands missed). Based on updated master (0b0071d) which includes: - Hook audit mode (rtk-ai#151) - Claude Code agents and skills (d8b5bb0) - tee raw output feature (rtk-ai#134) Migrated from feat/rust-hooks (571bd86) with conflict resolution for: - src/main.rs: Commands enum (preserved both hook audit + our hook commands) - src/init.rs: Hook registration (integrated both approaches) New files (src/cmd/ module): - mod.rs: Module declarations (10 modules, excluding safety/trash/gemini for PR 1) - hook.rs: Shared hook decision logic (21 tests, 3 safety tests removed for PR 2) - claude_hook.rs: Claude Code JSON protocol handler (18 tests) - lexer.rs: Quote-aware tokenizer (28 tests) - analysis.rs: Chain parsing and shellism detection (10 tests) - builtins.rs: cd/export/pwd/echo/true/false (8 tests) - exec.rs: Command executor with recursion guard (22 tests, safety dispatch removed for PR 2) - filters.rs: Output filter registry (5 tests) - predicates.rs: Context predicates (4 tests) - test_helpers.rs: Test utilities Modified files: - src/main.rs: Added Commands::Run, Commands::Hook, HookCommands enum, routing - src/init.rs: Changed patch_settings_json to use rtk hook claude binary command - hooks/rtk-rewrite.sh: Replaced 204-line bash script with 4-line shim (exec rtk hook claude) - Cargo.toml: Added which = 7 for PATH resolution - INSTALL.md: Added Windows installation section Windows support: - exec.rs:175-176: cfg!(windows) selects cmd /C vs sh -c for shell passthrough - predicates.rs:26: USERPROFILE fallback for Windows home directory - No bash, node, or bun dependency - rtk hook claude is a compiled Rust binary Tests: All 541 tests pass
This was referenced Feb 17, 2026
6 tasks
…commands Replaces stub check_for_hook_inner with full tokenize+native-path dispatch. Adds route_native_command() with replace_first_word/route_pnpm/route_npx helpers to route single parsed commands to optimized RTK subcommands. Chains (&&/||/;) and shellisms still use rtk run -c. No safety integration (PR rtk-ai#157 adds that). Mirrors ~/.claude/hooks/rtk-rewrite.sh routing table. Corrects shell script vitest double-run bug for pnpm vitest run flags.
a0ae712 to
c84955a
Compare
rtk has no `tail` subcommand — routing to "rtk tail" was silently broken (rtk would error "unrecognized subcommand"). Remove the Route entry so the command falls through to `rtk run -c '...'` correctly. Move the log-tailing test cases from test_routing_native_commands (which asserted the broken path) into test_routing_fallbacks_to_rtk_run where they correctly verify the rtk-run-c fallback behavior.
Port tests added during the ROUTES table integration that were missing from the v2 worktree: registry.rs: - 12 classify tests for Python/Go commands (pytest, go×4, ruff×2, pip×3, golangci-lint) that verify PATTERNS/RULES and ROUTES alignment - 11 lookup tests (test_lookup_*, test_no_duplicate_binaries_in_routes, test_lookup_is_o1_consistent) that verify O(1) HashMap routing hook.rs: - Extend test_routing_native_commands from 20 to 47 cases covering all ROUTES entries: docker, kubectl, curl, eslint, tsc, prettier, playwright, prisma, pytest, golangci-lint, ruff, pip, gh variants - Add test_routing_subcommand_filter_fallback (14 cases) verifying that Only[] subcommand filters correctly reject unmatched subcommands Total: 545 → 569 tests (+24)
Add rtk hook gemini for Gemini CLI BeforeTool hook handler. Different wire format from Claude: uses decision/reason fields, hook_event_name/tool_name guards, and run_shell_command matcher. Add rtk init --gemini for Gemini CLI integration with: - RTK.md deployment to ~/.gemini/ - GEMINI.md patching with @RTK.md reference - settings.json hook registration Multi-platform init: --claude (default) and --gemini flags. Both can coexist. Shared infrastructure: patch_settings_shared, patch_instruction_file, remove_hook_from_settings_file. Additive platform selection: rtk init with no flags sets up both Claude Code and Gemini CLI. --claude alone skips Gemini, --gemini alone skips Claude. Tests: 560 total (19 gemini_hook tests)
d2c2dca to
3c4f7fa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR 131 Part 3: Gemini CLI Hook Support
Branch:
feat/gemini-support-v2| Base:master(stacks on Part 1)Tests: 560 pass | Parallel to: Part 2 (zero file conflicts)
Split from: PR #131
New deps: None
PR: #158
Context
Addresses item 1 from FlorianBruniaux's split request:
FlorianBruniaux said "standalone" but code analysis shows
gemini_hook.rsimports 6 items fromhook.rs(types and functions). This PR depends on PR 1 for the shared hook infrastructure, but is parallel to PR 2 (data safety).Coordination with PR #141: FlorianBruniaux noted overlap with #141's JS-based hook. This PR achieves the same Windows support goal via compiled Rust binary -- no bash, node, or bun. Both PRs wanted cross-platform support; this approach has zero external runtime dependencies.
Merge Sequence
After PR 1 merges: retarget
feat/gemini-support-v2->master, then merge. Can merge before or after PR 2.Summary
Adds Gemini CLI support via
rtk hook geminiandrtk init --gemini. Shares 65% of hook logic with Claude Code -- only the JSON wire format differs.Impact: First multi-platform support. Future platforms (Cursor, Windsurf, etc.) only need a new protocol handler -- 35% code per platform, 65% shared.
rtk hook gemini-- BeforeTool handlerDifferent wire format from Claude:
hook_event_name(must be "BeforeTool") +tool_name(must be "run_shell_command")decision/reason/updated_input(notpermissionDecision/updatedInput)decision: "deny"works (unlike Claude bug #4669)rtk init --gemini-- SetupPatches
~/.gemini/settings.json, creates~/.gemini/GEMINI.mdwith@RTK.mdreference.Manual setup:
Multi-platform init logic
rtk initrtk init --claudertk init --geminirtk init --claude --geminiShared infrastructure extracted from
init.rs:patch_settings_shared()-- JSON patching for both Claude and Geminipatch_instruction_file()-- Adds @RTK.md reference to CLAUDE.md or GEMINI.mdremove_hook_from_settings_file()-- Uninstall hook entryChanges
6 files changed (+1037, -6)
New:
src/cmd/gemini_hook.rs(490 lines, 19 tests)Modified:
src/cmd/mod.rs(+gemini_hook),src/main.rs(+HookCommands::Gemini, +--gemini/--claude init flags),src/init.rs(+run_gemini(), +uninstall_gemini(), +patch_gemini_settings(), extracted shared functions),INSTALL.md(+Gemini setup),README.md(+Gemini integration section)Review Guide
Focus areas:
src/cmd/gemini_hook.rs-- Gemini protocol compliance, guard checkssrc/init.rs-- Multi-platform initialization, shared function extractionNot Included (Future)
Additional protocol handlers for other LLM CLIs (Cursor, Windsurf, Aider) will follow the same 35% code pattern established here.
Test Plan
cargo test-- 560 tests pass (gemini_hook: 19 new)echo '{"hook_event_name":"BeforeTool","tool_name":"run_shell_command","tool_input":{"command":"git status"}}' | cargo run -- hook gemini-- allow with rewriteecho '{"hook_event_name":"BeforeTool","tool_name":"write_file","tool_input":{"path":"test.txt"}}' | cargo run -- hook gemini-- NoOpinion (exit 0, no output)cargo run -- init --gemini --auto-patch-- settings patchedcargo run -- init-- both platforms configuredRelated PRs (Split from PR #131)
Merge order: Part 1 first → retarget Parts 2 & 3 to
master→ merge in any order