fix: include command name in err/test tracking labels#256
Open
sahilmgandhi wants to merge 1 commit intortk-ai:masterfrom
Open
fix: include command name in err/test tracking labels#256sahilmgandhi wants to merge 1 commit intortk-ai:masterfrom
sahilmgandhi wants to merge 1 commit intortk-ai:masterfrom
Conversation
rtk err and rtk test hardcoded their tracking labels to generic "rtk run-err" and "rtk run-test", losing the identity of the wrapped command in `rtk gain` output. Now they use the actual command (e.g., "rtk err pre-commit run --verbose") consistent with how other subcommands track themselves.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR stems from me writing a custom rtk script for company specific commands, and I wrapped them with
rtk err. I would like for them to show up as individual entries when I runrtk gainto see how many came from my custom commands versus built in rtk commands.Summary
rtk errandrtk testhardcoded their tracking labels to"rtk run-err"and"rtk run-test", which meantrtk gainlumped all wrapped commands into a single generic entry with no visibility into which command was actually runrtk err pre-commit run --verbose,rtk test cargo test), consistent with how other subcommands likertk gh pr viewalready track themselvesTest plan
cargo test runnerpassesrtk err <some-command>and verifyrtk gain --historyshows the full labelrtk gainper-command breakdown shows distinct entries for differentrtk errcommands