Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(build): Remove broken directives for windows compilation #20

Closed
wants to merge 1 commit into from
Closed

Fix(build): Remove broken directives for windows compilation #20

wants to merge 1 commit into from

Conversation

magicaldave
Copy link

No description provided.

@magicaldave magicaldave reopened this Aug 23, 2023
@ruabmbua
Copy link
Owner

I am curious, do you have any problems building on windows from master?
When I try this patch it starts failing for me, since cmake automatically seems to put the artifacts into Debug or Release subfolders.

@magicaldave
Copy link
Author

magicaldave commented Aug 28, 2023

Ah, yes, I haven't had the chance to correctly update this yet! When cross compiling on a non-windows host, for a Windows target, this patch fixes those builds, as enet itself doesn't end up in Debug/Release folders. However I did notice later during a CI build that an actual windows host does still need the original rule. So it actually needs to be modified to determine whether it's also a windows host, not target, doing the compile.

@ruabmbua
Copy link
Owner

b.t.w. see this issue that someone else had almost at the same time: #21

I will work out a proper fix, probably by patching the C libraries cmake build system to add a proper install target.

@ruabmbua
Copy link
Owner

ruabmbua commented Sep 1, 2023

Closed in favor of closed in favor of #22

@ruabmbua ruabmbua closed this Sep 1, 2023
@ruabmbua
Copy link
Owner

ruabmbua commented Sep 1, 2023

@magicaldave can you try to build with the version from #22? I struggle to get anything to build on mingw (I am not a windows user).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants