Add weekday pricing #1942
Add weekday pricing #1942
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1942 +/- ##
==========================================
+ Coverage 83.09% 83.21% +0.11%
==========================================
Files 100 100
Lines 3526 3544 +18
==========================================
+ Hits 2930 2949 +19
+ Misses 596 595 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Passing run #3053 ↗︎
Details:
Review all test suite changes for PR #1942 ↗︎ |
|||||||||||||||
frontend/src/components/pages/cabins/booking/Steps/calculatePrice.ts
Outdated
Show resolved
Hide resolved
| let currentDate = dayjs(startDate); | ||
| const finalDate = dayjs(endDate); | ||
| let weekdayNights = 0; | ||
| let weekendNights = 0; | ||
| let totalPrice = 0; | ||
| while (currentDate.isBefore(finalDate, "day")) { | ||
| // Last day has no night. | ||
| if (currentDate.day() === 5 || currentDate.day() === 6) { | ||
| // 5 = Friday to sat, 6 = Saturday to sunday | ||
| weekendNights++; | ||
| } else { | ||
| weekdayNights++; | ||
| } | ||
| currentDate = currentDate.add(1, "day"); |
There was a problem hiding this comment.
I'm slightly concerned that we have to duplicate the backend logic here. I suggest that we instead add a price-query or something similar and rely on the backend logic to calculate the price. That way, we won't accidentally end up with different prices.
Co-authored-by: Lars Waage <46653859+larwaa@users.noreply.github.com>
|
Passing run #3054 ↗︎
Details:
Review all test suite changes for PR #1942 ↗︎ |
|||||||||||||||
This pull request implements the requested changes to cabin pricing.