Add Calcite follow-up ticket

rubenada · Apr 15, 2024 · f3b8a78 · f3b8a78
1 parent b25a0be
commit f3b8a78
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/core/src/main/java/org/apache/calcite/adapter/enumerable/EnumUtils.java b/core/src/main/java/org/apache/calcite/adapter/enumerable/EnumUtils.java
@@ -355,7 +355,7 @@ public static Expression convert(Expression operand, Type fromType,
       return operand;
     }
 
-    // TODO consider using Expressions#convertChecked to throw exception in case of overflow
+    // TODO use Expressions#convertChecked to throw exception in case of overflow (CALCITE-6366)
 
     // E.g. from "Short" to "int".
     // Generate "x.intValue()".

diff --git a/core/src/test/java/org/apache/calcite/test/JdbcTest.java b/core/src/test/java/org/apache/calcite/test/JdbcTest.java
@@ -8466,7 +8466,7 @@ private void checkGetTimestamp(Connection con) throws SQLException {
         .returnsUnordered("VAL=2500.55");
   }
 
-  @Disabled
+  @Disabled("CALCITE-6366")
   @Test void bindOverflowingTinyIntParameter() {
     final String sql =
         "with cte as (select cast(300 as smallint) as empid)"