Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix: #1119] Fix an incorrect autocorrect for Rails/RedundantActiveRecordAllMethod when all has parentheses #1120

Conversation

masato-bkn
Copy link
Contributor

Fix: #1119

This PR fixes an incorrect autocorrect for Rails/RedundantActiveRecordAllMethod when all has parentheses.


  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.
  • [ ] If this is a new cop, consider making a corresponding update to the Rails Style Guide.

…ActiveRecordAllMethod` when `all` has parentheses
@koic koic merged commit 85de912 into rubocop:master Sep 18, 2023
4 checks passed
@koic
Copy link
Member

koic commented Sep 18, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect auto-correction for Rails/RedundantActiveRecordAllMethod when all has parentheses
2 participants