Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] Prevent unintended auto-correct with after_generate #1123

Merged
merged 1 commit into from
Sep 15, 2023

Conversation

sinsoku
Copy link
Contributor

@sinsoku sinsoku commented Sep 15, 2023

Some rails generators may not generate *.rb. (e.g. bin/rails g stimulus)
In this case, parsable_files is empty, so RuboCop will parse all files.
This behavior is not intended, so it fixes the doc.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • [-] Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • [-] Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • [-] Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.
  • [-] If this is a new cop, consider making a corresponding update to the Rails Style Guide.

Some `rails generators` may not generate `*.rb`. (e.g. `bin/rails g stimulus`)
In this case, `parsable_files` is empty, so RuboCop will parse all files.
This behavior is not intended, so it fixes the doc.
@koic koic merged commit e78e8af into rubocop:master Sep 15, 2023
4 checks passed
@koic
Copy link
Member

koic commented Sep 15, 2023

Good catch 👍

@sinsoku sinsoku deleted the update-rails-tips branch September 15, 2023 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants