Make Rails/EagerEvaluationLogMessage
enabled by default
#1364
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On issue #1355 we had some discussions about the
Rails/EagerEvaluationLogMessage
cop. In particular, @Earlopain did some useful benchmarks of some possible scenarios.After seeing the benchmarks, it's pretty obvious to note that offenses that this cop reports (that is, interpolated strings passed to
Rails.logger.debug
) are very slow compared to the form that the cop allows (that is, blocks passed toRails.logger.debug
).With that being said, considering that the performance hit is now clear between the 2 forms, we might as well enable this cop by default.
Before submitting the PR make sure the following are checked:
[Fix #issue-number]
(if the related issue exists).master
(if not - rebase it).bundle exec rake default
. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.md
if the new code introduces user-observable changes. See changelog entry format for details.