Fix I18n.interpolate when ActiveSupport::SafeBuffer passed as argument

ruby-i18n · Aug 31, 2013 · 913e40e · 913e40e
1 parent 3e53950
commit 913e40e
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/lib/i18n/interpolate/ruby.rb b/lib/i18n/interpolate/ruby.rb
@@ -22,7 +22,7 @@ def interpolate_hash(string, values)
         if match == '%%'
           '%'
         else
-          key = ($1 || $2).to_sym
+          key = ($1 || $2 || match.tr("%{}", "")).to_sym
           value = if values.key?(key)
                     values[key]
                   else

diff --git a/test/i18n/interpolate_test.rb b/test/i18n/interpolate_test.rb
@@ -58,6 +58,17 @@ class I18nInterpolateTest < Test::Unit::TestCase
   def test_sprintf_mix_unformatted_and_formatted_named_placeholders
     assert_equal "foo 1.000000", I18n.interpolate("%{name} %<num>f", :name => "foo", :num => 1.0)
   end
+
+  class RailsSafeBuffer < String
+
+    def gsub(*args, &block)
+      to_str.gsub(*args, &block)
+    end
+
+  end
+  test "with String subclass that redefined gsub method" do
+    assert_equal "Hello mars world", I18n.interpolate(RailsSafeBuffer.new("Hello %{planet} world"), :planet => 'mars') 
+  end
 end
 
 class I18nMissingInterpolationCustomHandlerTest < Test::Unit::TestCase