Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use proper locale in history encoding test #1008

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

tompng
Copy link
Member

@tompng tompng commented Sep 24, 2024

$ LANG=C irb
irb(main):001> IRB.conf[:LC_MESSAGES].encoding
=> "US-ASCII"

To emulate this case in history encoding test, (which is the original intention of this test)
IRB::Locale.new("en_US.ASCII").encoding #=> #<Encoding:US-ASCII> is better than IRB::Locale.new("C").encoding #=> #<Encoding:UTF-8>

This fix will avoid test failure in Reline's un-opened pull request ruby/reline#751.

@tompng tompng merged commit f6b06a9 into ruby:master Sep 24, 2024
30 checks passed
@tompng tompng deleted the history_test_encoding_fix branch September 24, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant