Fix invalid byte sequence in autoindent calculation #631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
st0012
approved these changes
Jul 4, 2023
| @@ -33,7 +33,7 @@ def teardown | |||
| def calculate_indenting(lines, add_new_line) | |||
| lines = lines + [""] if add_new_line | |||
| last_line_index = lines.length - 1 | |||
| byte_pointer = lines.last.length | |||
| byte_pointer = lines.last.bytesize | |||
There was a problem hiding this comment.
The test seems to capture the issue even without this change?
There was a problem hiding this comment.
Yes. This change don't affect the added test. I just fixed it because I found it doing wrong with byte_pointer.
|
I think ruby/reline#562 will also fix this problem. |
|
Closing this because this pull request is a workaround, and it's fixed in Reline 0.3.6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Workaround for #627
The root cause of this issue is several (more than two) bugs in Reline.
ruby/reline#553
Reline sometimes passes wrong byte_pointer to auto_indent_proc.
If Reline's bug is not going to be fixed soon, IRB needs to validate encoding of
byteslice(0, byte_pointer)before using it.