Fix kill pager pid throwing Errno::ESRCH when pager process already terminated #989
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #847
In some case, when IRB receives IRB::Abort, pager process might be already terminated.
This can happen with timing or pager's problem.
Timing problem
When there is a
sleep 1
just afterpager.close
, (pressq
to terminate pager and press \C-c within 1 sec) process might be already terminated. I can't reproduce this without insertingsleep 1
but it could potentially happen.Pager's problem
Less
somehow does not receive\C-c
when paging content is large (more than 72KB) and has many lines.Just after exiting pager by typing
q
, IRB receives the previous\C-c
and IRB tries toProcess.kill pid
but the process is already terminated.