Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow Float & nil for ConditionVariable#wait 2nd arg #1397

Merged
merged 1 commit into from
Aug 14, 2023
Merged

Allow Float & nil for ConditionVariable#wait 2nd arg #1397

merged 1 commit into from
Aug 14, 2023

Conversation

ParadoxV5
Copy link
Contributor

Fixes #1306

#good-first-issue

@ParadoxV5 @lloeki
Allow Float & nil for ConditionVariable#wait 2nd arg
dc930f4 
Fixes ruby#1306

Co-Authored-By: Loic Nageleisen <loic.nageleisen@gmail.com>
@ParadoxV5
Copy link
Contributor Author

P.S. there seems to be no associated test

soutaro
soutaro approved these changes Aug 14, 2023
View reviewed changes
Copy link
Member

@soutaro soutaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 👍

@soutaro soutaro added this to the RBS 3.2 milestone Aug 14, 2023
@soutaro soutaro added this pull request to the merge queue Aug 14, 2023
Merged via the queue into ruby:master with commit 1ca61c4 Aug 14, 2023
23 checks passed
@ParadoxV5 ParadoxV5 deleted the 1306-ConditionVariable-wait-arg2 branch August 14, 2023 18:33
@soutaro soutaro added the Released PRs already included in the released version label Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soutaro soutaro soutaro approved these changes

Assignees
No one assigned
Labels
Released PRs already included in the released version
Milestone
RBS 3.2
Development

Successfully merging this pull request may close these issues.

ConditionVariable#wait signature is too narrow
2 participants
@ParadoxV5 @soutaro