stdlib: Make the block arguments of Kernel#proc untyped #2036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the block argument of `Kernel#proc` to UntypedFunction. Then the arguments of the block become untyped instead of nil. It allows users to override the type via comment annotation. For example: ``` proc do |a, b, c| # @type var a: String # @type var b: Integer # @type var c: Symbol end ``` I found this problem on the Steep repo. https://github.com/soutaro/steep/blob/v1.8.0/lib/steep.rb#L169-L176
tk0miya
force-pushed
the
stdlib/Kernel.proc
branch
from
22f23a3
to
14e92e1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the block argument of
Kernel#procto UntypedFunction. Then the arguments of the block become untyped instead of nil.It allows users to override the type via comment annotation.
For example:
I found this problem on the Steep repo.
https://github.com/soutaro/steep/blob/v1.8.0/lib/steep.rb#L169-L176