Add assertion to auto_indent_proc's parameter, add Ctrl-d exit test #574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
st0012
reviewed
Jul 18, 2023
tompng
force-pushed
the
auto_indent_proc_assertion
branch
from
e3c31cc
to
fe276df
Compare
st0012
approved these changes
Jul 19, 2023
matzbot
pushed a commit
to ruby/ruby
that referenced
this pull request
Jul 19, 2023
Ctrl-d exit test (ruby/reline#574) * Add auto_indent_proc's parameter assertion in multiline_repl * Add rendering test for Ctrl-d exit ruby/reline@46db71132a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reline was passing
lines=[nil]to auto_indent_proc when exit with Ctrl-d. This pull request add assertion to auto_indent_proc's parameter in rendering test and add Ctrl-d exit test.Without #571, test added in this pull request will fail. https://github.com/tompng/reline/actions/runs/5592504740/jobs/10225040010
I think there are several bug that wrong byte_pointer is passed to auto_indent_proc.
Adding a strict assertion for byte_pointer will make many test fail, so I added a loose assertion for now.