Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Concatenate some rendeing test #749

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Concatenate some rendeing test #749

wants to merge 2 commits into from

Conversation

tompng
Copy link
Member

@tompng tompng commented Sep 9, 2024 •
edited
Loading

Depend on #747

Some test should be concatenated for readability.

def test_foo1
  long_setup
  write foo1
  assert_screen(foo1)
end

def test_foo1_and_foo2
  long_setup
  write foo1
  write foo2
  assert_screen(foo2)
end

def test_foo1_and_foo2_and_foo3
  long_setup
  write foo1
  write foo2
  write foo3
  assert_screen(foo3)
end

# ↓

def test_foo
  long_setup
  write foo1
  assert_screen(foo1)
  write foo2
  assert_screen(foo2)
  write foo3
  assert_screen(foo3)
end

Concatenated tests

test_bracketed_paste_with_undo
test_bracketed_paste_with_undo_redo

test_longer_than_screen_height
test_longer_than_screen_height_with_scroll_back
test_longer_than_screen_height_with_complex_scroll_back

test_autocomplete_long_with_scrollbar
test_autocomplete_long_with_scrollbar_scroll

@tompng
Make rendering test faster using updated yamatanooroti
6e7198b
@tompng
Concatenate some rendeing test
4e331cc 
Some test should be concatenated for readability.
Example: undo test and undo_and_redo test can be concatenated.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tompng