Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce calls to StringScanner.new() #108

Merged
merged 1 commit into from
Jan 31, 2024
Merged

Reduce calls to StringScanner.new() #108

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion lib/rexml/parsers/baseparser.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,7 @@ class BaseParser
def initialize( source )
self.stream = source
@listeners = []
@attributes_scanner = StringScanner.new('')
end

def add_listener( listener )
Expand Down Expand Up @@ -601,7 +602,8 @@ def parse_attributes(prefixes, curr_ns)
return attributes, closed if raw_attributes.nil?
return attributes, closed if raw_attributes.empty?

scanner = StringScanner.new(raw_attributes)
@attributes_scanner.string = raw_attributes
naitoh marked this conversation as resolved.
Show resolved Hide resolved
scanner = @attributes_scanner
until scanner.eos?
if scanner.scan(/\s+/)
break if scanner.eos?
Expand Down