Skip to content

Commit

Permalink
Revert "Try to close server during shutdown"
Browse files Browse the repository at this point in the history
* This reverts commit c96dc4f.
* It causes transient errors: #925
  • Loading branch information
eregon committed Mar 28, 2022
1 parent c96dc4f commit 920afb0
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 4 deletions.
4 changes: 2 additions & 2 deletions library/socket/fixtures/classes.rb
Original file line number Diff line number Diff line change
Expand Up @@ -118,14 +118,14 @@ def service(socket)

socket.send data, 0
ensure
socket.close unless socket.closed?
socket.close
end
end

def shutdown
log "SpecTCPServer shutting down"
@server.close unless @server.closed?
@thread.join
@server.close
end

def log(message)
Expand Down
3 changes: 1 addition & 2 deletions library/socket/udpsocket/send_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -16,14 +16,13 @@
retry
end
ensure
@server.close unless @server.closed?
@server.close if !@server.closed?
end
end
Thread.pass while @server_thread.status and !@port
end

after :each do
@server.close unless @server.closed?
@server_thread.join
end

Expand Down

0 comments on commit 920afb0

Please sign in to comment.