Add specs for ENV#clone and #dup
#1025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AI-Mozi
changed the title
ENV#clone and #dupENV#clone and #dup
AI-Mozi
force-pushed
the
add_specs_for_env_clone_dup
branch
from
9c45917
to
161c43e
Compare
|
Thank you for the specs! |
| }.should raise_error(TypeError, /Cannot clone ENV, use ENV.to_h to get a copy of ENV as a hash/) | ||
| end | ||
| end | ||
| end |
There was a problem hiding this comment.
The existing specs for ENV#clone could be improved in bit.
The previous behaviour was to return self:
# Ruby 3.1.3
ENV.equal? ENV.clone # => => true
ENV.object_id == ENV.clone.object_id # => trueSo such a case could be added as well (with version guard ruby_version_is ""..."3.2")
| -> { | ||
| ENV.clone | ||
| }.should raise_error(TypeError, /Cannot clone ENV, use ENV.to_h to get a copy of ENV as a hash/) | ||
| end |
There was a problem hiding this comment.
This case could also be improved to check that all the allowed arguments (freeze: nil, freeze: true, freeze: false) lead to the TypeError exception.
| }.should raise_error(ArgumentError) | ||
| end | ||
|
|
||
| it "raises ArgumentError when keyword argument is not 'freeze'" do |
There was a problem hiding this comment.
suggestion:
it "raises ArgumentError when passed keyword argument other than 'freeze'" do
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1016
[Bug #17767]