Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change ruby version for Kernel#trust, #untrust and #untrusted #1031

Merged
merged 1 commit into from
May 17, 2023
Merged

Change ruby version for Kernel#trust, #untrust and #untrusted #1031

merged 1 commit into from
May 17, 2023

Conversation

AI-Mozi
Copy link
Contributor

@AI-Mozi AI-Mozi commented May 16, 2023

#1016
Feature #16131

The following deprecated methods are removed.
[ ] Kernel#trust, Kernel#untrust, Kernel#untrusted?

I broke my #1024 branch so I created new one

@AI-Mozi AI-Mozi marked this pull request as ready for review May 16, 2023 14:57
@andrykonchin
Copy link
Member

andrykonchin commented May 16, 2023 •
edited by eregon
Loading

Could you please follow the @eregon's suggestion and also check that respond_to? returns false in Ruby 3.2?

I've found several similar cases in the existing specs when some deprecated method is removed:

@AI-Mozi AI-Mozi force-pushed the change_kernel_trust_methods branch from 3c5690f to 35dc26c Compare May 17, 2023 08:29
@AI-Mozi AI-Mozi mentioned this pull request May 17, 2023
Merged
@andrykonchin
Copy link
Member

Thank you for the specs!

@andrykonchin andrykonchin merged commit b71a276 into ruby:master May 17, 2023
@eregon eregon mentioned this pull request May 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrykonchin andrykonchin andrykonchin approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AI-Mozi @andrykonchin