Change #public?, #protected? and #private? specs for Method
#1033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AI-Mozi
force-pushed
the
add_specs_for_method_pub_priv_prot
branch
from
8e3c032
to
07ecf8f
Compare
AI-Mozi
force-pushed
the
add_specs_for_method_pub_priv_prot
branch
from
07ecf8f
to
551e0f2
Compare
core/unboundmethod/private_spec.rb
Outdated
| ruby_version_is "3.2" do | ||
| it "has been removed" do | ||
| obj = UnboundMethodSpecs::Methods.new | ||
| obj.method(:my_private_method).should_not.respond_to?(:private?) |
There was a problem hiding this comment.
major: Without unbind it will test an instance of Method, not UnboundMethod
Suggested change
| obj.method(:my_private_method).should_not.respond_to?(:private?) | |
| obj.method(:my_private_method).unbind.should_not.respond_to?(:private?) |
…nd `UnboundMethod`
AI-Mozi
force-pushed
the
add_specs_for_method_pub_priv_prot
branch
from
551e0f2
to
e8e2c0d
Compare
|
Thank you for the specs! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1016
[Bug #18729] [Bug #18751] [Bug #18435]