Add more specs for OpenSSL::Digest #1054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And move the current digest_spec into the new folder.
2 tasks
|
Only after pushing this change I noticed the Rubocop complaints about the style |
herwinw
added a commit
to herwinw/natalie
that referenced
this pull request
Aug 22, 2023
Imported from ruby/spec#1054 and subject to change.
herwinw
added a commit
to herwinw/natalie
that referenced
this pull request
Aug 22, 2023
Imported from ruby/spec#1054 and subject to change.
herwinw
added a commit
to herwinw/natalie
that referenced
this pull request
Aug 24, 2023
Imported from ruby/spec#1054 and subject to change. They have been imported into the natalie folder to break a dependeny on the change request of ruby-spec.
herwinw
added a commit
to herwinw/natalie
that referenced
this pull request
Aug 29, 2023
Imported from ruby/spec#1054 and subject to change. They have been imported into the natalie folder to break a dependeny on the change request of ruby-spec.
herwinw
added a commit
to herwinw/natalie
that referenced
this pull request
Aug 30, 2023
Imported from ruby/spec#1054 and subject to change. They have been imported into the natalie folder to break a dependeny on the change request of ruby-spec.
herwinw
added a commit
to herwinw/natalie
that referenced
this pull request
Sep 23, 2023
Imported from ruby/spec#1054 and subject to change. They have been imported into the natalie folder to break a dependeny on the change request of ruby-spec.
herwinw
added a commit
to herwinw/natalie
that referenced
this pull request
Sep 24, 2023
Imported from ruby/spec#1054 and subject to change. They have been imported into the natalie folder to break a dependeny on the change request of ruby-spec.
herwinw
added a commit
to herwinw/natalie
that referenced
this pull request
Sep 30, 2023
Imported from ruby/spec#1054 and subject to change. They have been imported into the natalie folder to break a dependeny on the change request of ruby-spec.
We use this notation on purpose to be able to test the behaviour.
herwinw
force-pushed
the
openssl_digest
branch
from
4fd121b
to
24c460f
Compare
|
I think I've addressed all the issues in the latest version |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current specs are very limited