Add missing checks for to_str calls in ENV specs #1056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 20, 2023
seven1m
reviewed
Aug 20, 2023
core/env/delete_spec.rb
Outdated
| @@ -41,6 +41,14 @@ | |||
| ENV["foo"].should == nil | |||
| end | |||
|
|
|||
| it "removes the variable coerced wit #to_str" do | |||
There was a problem hiding this comment.
I guess that was a witty comment
There was a problem hiding this comment.
Resolved in the latest version
A number of specs did mention the calls to to_str, but did not test the full path.
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A number of specs did mention the calls to to_str, but did not test the full path.