Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move version guard in fiber storage spec to top level #1061

Merged
merged 1 commit into from
Aug 29, 2023

Conversation

herwinw
Copy link
Member

@herwinw herwinw commented Aug 28, 2023

This feature is introduced in Ruby 3.2, so by wrapping everything in the version guard there is no more need to repeat in at every block.

@herwinw
Copy link
Member Author

herwinw commented Aug 28, 2023

This was requested in a review comment in #1058, but it was out of scope in that change request.

@herwinw herwinw changed the title Move version in fiber storage spec to top level Move version guard in fiber storage spec to top level Aug 28, 2023
This feature is introduced in Ruby 3.2, so by wrapping everything in the
version guard there is no more need to repeat in at every block.
@herwinw herwinw force-pushed the fiber_storage_version_guard branch from bbe72fe to a78aeca Compare August 28, 2023 14:44
Copy link
Member

@eregon eregon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@eregon eregon merged commit 7a818ec into ruby:master Aug 29, 2023
10 checks passed
@herwinw herwinw deleted the fiber_storage_version_guard branch August 29, 2023 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants