Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for warnings when passing block to creation of new IO object #1087

Merged
merged 3 commits into from
Sep 30, 2023
Merged

Add tests for warnings when passing block to creation of new IO object #1087

merged 3 commits into from
Sep 30, 2023

Commits on Sep 30, 2023

  1. Wrap tests for unixserver in an outer guard block 

    Normalize to `with_feature :unix_socket`, which is more descriptive and
generic than checking for windows.
    @herwinw
    herwinw committed Sep 30, 2023
    Configuration menu
    Copy the full SHA
    6b66e7a View commit details
    Browse the repository at this point in the history

  2. Wrap tests for unixsocket in an outer guard block 

    Normalize to `with_feature :unix_socket`, which is more descriptive and
generic than checking for windows.
    @herwinw
    herwinw committed Sep 30, 2023
    Configuration menu
    Copy the full SHA
    26d2899 View commit details
    Browse the repository at this point in the history

  3. Add tests for warnings when passing block to creation of new IO object 

    Update the spec for StringIO.new to match the style of the other ones,
and include the check to see the block is not used.
    @herwinw
    herwinw committed Sep 30, 2023
    Configuration menu
    Copy the full SHA
    61167fd View commit details
    Browse the repository at this point in the history