Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand specs for Thread variables #1127

Merged
merged 7 commits into from
Jun 26, 2024
Merged

Commits on Jan 9, 2024

  1. Add parentheses to calles of thread_variable_set

    This makes the code more consistent.
    herwinw committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    0ce2ba2 View commit details
    Browse the repository at this point in the history
  2. Clarify comment for Thread#thread_variables

    The old one was a copy-paste of the setter.
    herwinw committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    977f80d View commit details
    Browse the repository at this point in the history
  3. Expand specs for Thread#thread_variable_set

    * Test with frozen Thread
    * Test with nil value which removes the entry
    * Test different key types
    herwinw committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    0321205 View commit details
    Browse the repository at this point in the history
  4. Expand specs for Thread#thread_variable_get

    * Test with frozen Thread
    * Test different key types
    
    The key type behaviour differs from Thread#thread_variable_set, keys
    that raise a TypeError when setting result in a nil value when getting.
    herwinw committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    2f8508e View commit details
    Browse the repository at this point in the history
  5. Expand specs for Thread#thread_variable?

    * Test with frozen Thread
    * Test different key types
    
    The key type behaviour is similar to Thread#thread_variable_get?
    herwinw committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    7ab86dc View commit details
    Browse the repository at this point in the history
  6. Expand specs for Thread#thread_variables

    * Test different key types
    
    This shows the Symbol type being used as the internal type.
    herwinw committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    4cd2a60 View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2024

  1. Reword Thread #thread_variable_get/#thread_variable_set/#thread_varia…

    …ble?/#thread_variables specs titles
    andrykonchin committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    89328e4 View commit details
    Browse the repository at this point in the history