Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add specs for prepend modifying ancestor chain #1136

Merged
merged 1 commit into from
Feb 12, 2024
Merged

Add specs for prepend modifying ancestor chain #1136

merged 1 commit into from
Feb 12, 2024

Conversation

dushyantss
Copy link
Contributor

This PR adds specs for Bug #17423

From:

Module#prepend now modifies the ancestor chain if the receiver
already includes the argument. Module#prepend still does not
modify the ancestor chain if the receiver has already prepended
the argument. [Bug #17423]

eregon
eregon approved these changes Feb 12, 2024
View reviewed changes
Copy link
Member

@eregon eregon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@eregon eregon merged commit 24a5994 into ruby:master Feb 12, 2024
13 checks passed
@dushyantss dushyantss deleted the 17423-prepend-modifies-ancestor-chain branch February 12, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eregon eregon eregon approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dushyantss @eregon