Add spec for compare_by_identity behaviour of Hash#replace #1160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This one was used in just one location, moving the specs inline.
| @@ -1,51 +0,0 @@ | |||
| describe :hash_replace, shared: true do | |||
| it "replaces the contents of self with other" do | |||
There was a problem hiding this comment.
Yeah, makes sense. This shared example was used also for Hash#initialize_copy but in d3f83d1 specs for Hash#initialize_copy were removed.
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The spec has originally been written by @seven1m in natalie-lang/natalie#2104
This change does include a cleanup of the specs of
Hash#replace: it used a shared spec, but this was the only user of this spec. This shared spec has been moved inline into the main file.