Add specs for String#encode :fallback option #1164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seven1m
force-pushed
the
string-encode-fallback
branch
2 times, most recently
from
c070b2d
to
f0c15a9
Compare
seven1m
commented
Jun 23, 2024
seven1m
force-pushed
the
string-encode-fallback
branch
from
f0c15a9
to
bccc2a7
Compare
|
Thank you! |
seven1m
added a commit
to natalie-lang/natalie
that referenced
this pull request
Jun 24, 2024
New specs here were upstreamed in ruby/spec#1164 and ruby/spec#1165.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As far as I can tell, this is the only place where this option was tested, and we only tested a proc for
String#encode(notString#encode!).