Add shared specs when precision is passed in for Integer#floor, Float#floor and Integer#ceil, Float#ceil #1186
Conversation
This spec can be shared between Integer#floor and Float#floor and improves coverage of cases where precision is passed in.
This spec can be shared between Integer#ceil and Float#ceil and improves coverage of cases where precision is passed in.
|
Note that cases where |
Could you include those too, but under BTW it's fine if you change specs directly in the ruby/ruby PR for convenience, that ensures the specs are run with the fix and work on ruby-head. |
Yep, I'll add the specs for the new behaviour in ruby/ruby#11257 once this PR is merged. |
|
|
||
| ruby_bug "#20654", ""..."3.4" do | ||
| it "returns 0 when the return value overflows fixnum" do | ||
| send(@method, -123).ceil(-100).should.eql?(0) |
There was a problem hiding this comment.
The behavior under a ruby_bug guard should be the correct behavior, not the buggy behavior (see CONTRIBUTING.md)
There was a problem hiding this comment.
Ah I see. I misunderstood. I've fixed it in the latest commit.
peterzhu2118
force-pushed
the
pz-floor-ceil-share
branch
from
5a3820a
to
37ea091
Compare
|
Thanks for the new specs! |
There is poor spec coverage of when precision is passed into Integer#floor, Float#floor, Integer#ceil, Float#ceil. This PR adds some specs for when precision is passed in.