Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add spec for Integer#zero? overrides Numeric#zero? #874

Merged
merged 1 commit into from
Oct 12, 2021
Merged

add spec for Integer#zero? overrides Numeric#zero? #874

merged 1 commit into from
Oct 12, 2021

Conversation

lxxxvi
Copy link
Contributor

@lxxxvi lxxxvi commented Oct 11, 2021

Hello 👋

Here's my attempt to cover this from #823

Integer#zero? overrides Numeric#zero? for optimization. [Misc #16961]

As always I am looking forward to getting feedback, thank you.

eregon
eregon approved these changes Oct 12, 2021
View reviewed changes
Copy link
Member

@eregon eregon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@eregon eregon merged commit 4da993b into ruby:master Oct 12, 2021
@lxxxvi lxxxvi deleted the Integer-overrides-zero-method branch January 12, 2023 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eregon eregon eregon approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lxxxvi @eregon