Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add spec for feature 17187 #876

Merged
merged 1 commit into from
Oct 15, 2021
Merged

Add spec for feature 17187 #876

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions library/socket/tcpsocket/shared/new.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,5 +75,12 @@
@socket.addr[1].should be_kind_of(Integer)
@socket.addr[2].should =~ /^#{@hostname}/
end

ruby_version_is "3.0" do
it "connects to a server when passed connect_timeout argument" do
@socket = TCPSocket.send(@method, @hostname, @server.port, connect_timeout: 1)
@socket.should be_an_instance_of(TCPSocket)
end
end
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good start, but we should also test what happens if it does actually time out.

I think that should be easy to emulate with a manual TCPServer.new/TCPServer.open (see the logic in SpecTCPServer to get port and hostname),
and then never calling accept.
Then we should get an exception after the specified timeout.

Would you like to try adding that?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, #877 added something like that.

end
end