Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add specs to feature 14183 #878

Merged
merged 3 commits into from
Oct 15, 2021
Merged

Add specs to feature 14183 #878

merged 3 commits into from
Oct 15, 2021

Conversation

sergio-hilgert
Copy link

Issue #823

Add specs for the feature https://bugs.ruby-lang.org/issues/14183

eregon
eregon reviewed Oct 15, 2021
View reviewed changes
language/method_spec.rb Outdated Show resolved Hide resolved
eregon
eregon reviewed Oct 15, 2021
View reviewed changes
language/method_spec.rb Outdated Show resolved Hide resolved
eregon
eregon reviewed Oct 15, 2021
View reviewed changes
language/method_spec.rb Outdated Show resolved Hide resolved
eregon
eregon reviewed Oct 15, 2021
View reviewed changes
Copy link
Member

@eregon eregon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR, could you address my review?

@sergio-hilgert
Copy link
Author

Hey @eregon, thanks for the review! I've applied the changes!

eregon
eregon approved these changes Oct 15, 2021
View reviewed changes
Copy link
Member

@eregon eregon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I pushed some fixes and improvements on top as the specs were not passing yet.

@eregon eregon merged commit 7b514bc into ruby:master Oct 15, 2021
@sergio-hilgert sergio-hilgert deleted the feature-14183 branch October 15, 2021 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eregon eregon eregon approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sergio-hilgert @eregon