Add specs to cover the bug 9573 #879
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergio-hilgert
changed the title
eregon
reviewed
Oct 16, 2021
|
|
||
| A.include B1 | ||
| B1.include C2 | ||
| A.ancestors.should == [A, B1, C2, Object, ModuleSpecs::IncludedInObject, PP::ObjectMixin, Kernel, BasicObject] |
There was a problem hiding this comment.
We need to only check the first 4 ancestors here, since there can be various modules included in Object and that we can't test here easily.
I think something like [A, B1, C2] + Object.ancestors is nice.
eregon
reviewed
Oct 16, 2021
| @@ -99,3 +99,57 @@ module ModuleSpecs::Modules::Klass; end | |||
| d.name.should == "ModuleSpecs_CS2::D" | |||
| end | |||
| end | |||
|
|
|||
| ruby_version_is "3.0" do | |||
| describe "Include" do | |||
There was a problem hiding this comment.
Could you move these specs to core/module/include_spec.rb and core/module/prepend_spec.rb?
language/ is for syntax, and include/prepend are just regular Ruby methods should should be tested in core/.
|
@sHilgert Could you do the suggested changes? |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #823
Add specs to the bug https://bugs.ruby-lang.org/issues/9573